fix: debug the ESLint config file #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for findadoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
c3dafa7 to
0a8c193
Compare
|
LGTM as a junior new on this codebase. Looks like you had your work cut out for you! 🙌 |
Previously, the eslint file is not applying the linting and styling rules to our code
6959f2e to
ffc816a
Compare
ermish
reviewed
Mar 14, 2024
There was a problem hiding this comment.
@Anissa3005 @theyokohamalife I added some comments. We should make a new issue and fix some of these.
| '.nuxt/*', | ||
| 'coverage/*', | ||
| 'cypress/videos/*', | ||
| '.yarn/*' | ||
| '.yarn/*', | ||
| 'typedefs/gqlTypes.ts' |
There was a problem hiding this comment.
we don't want this to be gitignored
There was a problem hiding this comment.
we want to know when changes are made to the api and this is one of the easiest ways to see. It also makes the build faster when it already exists. (neglible though)
| { | ||
| languageOptions: { | ||
| parser: vuePlugin.parser, |
There was a problem hiding this comment.
I think this just removed the whole linting for vue files. We'll likely need to readd this back in
ermish
pushed a commit
that referenced
this pull request
Mar 18, 2024
* fix: debug the ESLint config file Previously, the eslint file is not applying the linting and styling rules to our code * chore: format files with new linting rules * fixup! chore: format files with new linting rules --------- Co-authored-by: theyokohamalife <lts001@gmail.com>
ermish
added a commit
that referenced
this pull request
Mar 18, 2024
* changed from apolloclient to graphql-request * updated queries with new fetch format * fixup! changed from apolloclient to graphql-request * cleaned up added semicolons * docs: add NabbeunNabi as a contributor for code (#410) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add Anissa3005 as a contributor for code (#411) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add evan-desu as a contributor for code (#412) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * Debug the ESLint config file (#409) * fix: debug the ESLint config file Previously, the eslint file is not applying the linting and styling rules to our code * chore: format files with new linting rules * fixup! chore: format files with new linting rules --------- Co-authored-by: theyokohamalife <lts001@gmail.com> * chore(deps): update graphqlcodegenerator monorepo (#408) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add tests for localeStore (#401) * test: add tests for localeStore Previously, there were no tests present for the localeStore. In this commit I have created tests for localeStore * fixup! test: add tests for localeStore * feat: add photos, titles, and names on about us (#406) This change adds the board members, developers and links to their linkedIn profiles for the ones that are currently available. There are tests for the additions as well. Changed the styling for the map container and main app in order to not have the footer cut through parts of the page. * merge fixes. rebuilt yarn * rebuilding yarn lock file * merge fixes. linting errors --------- Co-authored-by: Will Brammer <williamedwardbrammer@gmail.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Anissa Chadouli <anissa.chadouli@gmail.com> Co-authored-by: theyokohamalife <lts001@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #403
🔧 What changed
Previously, the eslint config file was not applying any of the rules to our codebase. This resulted in wring linting and styling on our codebase.
🧪 Testing instructions
To Do
It seems that at the moment the Vue Eslint is not yet supported for flat config files, vuejs/eslint-plugin-vue#1291, not sure if I can get it to work.