Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6791 Raise 404 when editing a pseud for a user that doesn't exist #5047

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lou-codes
Copy link

@lou-codes lou-codes commented Feb 2, 2025

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6791

Purpose

When navigating to a pseud edit page for a user that doesn't exist (/users/fake_user/pseuds/pseud/edit), we should return a 404 error, instead of a 500

Testing Instructions

Replication steps from JIRA:

  1. Log in as an admin who can edit pseuds (policy_and_abuse or superadmin)
  2. Try to edit a pseud for a nonexistent user. For example, assuming the user no_testy does not exist, enter this URL in your browser: https://test.archiveofourown.org/users/no_testy/pseuds/no_testy/edit

References

Are there other relevant issues/pull requests/mailing list discussions?
Linked jira issue AO3-6790 to raise 404 when editing a pseud that doesn't exist, and its PR.

Credit

lou (she/her)

@lou-codes lou-codes marked this pull request as ready for review February 3, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant