-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-6890 Add puma worker killer gem #5038
AO3-6890 Add puma worker killer gem #5038
Conversation
31cd84e
to
7f6e0f3
Compare
Based on the docs I think you might have to call |
@@ -0,0 +1,3 @@ | |||
PumaWorkerKiller.config do |config| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a before_fork
hook, or a call to start
? Would the gem be activated this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm pretty sure Bilka is right. Based on the docs (which I am having a little trouble following since there seem to be multiple paths to configuring it), we need to do this in Ansible instead. The linked PR (visible only to folks with read+ access to that repo) needs to do it instead, since we don't have config/puma.rb
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting to do it in the config/puma.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I removed this file and moved it to Ansible's config/puma.rb
in https://github.com/OTWSystems/ansible/pull/146
https://otwarchive.atlassian.net/browse/AO3-6890