AO3-6737 Fix display of recent bookmarks module #5027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjaustin
approved these changes
Jan 14, 2025
|
looks like this also fixes the save/saved button being unclickable (in the default skin) or completely hidden (in reversi) on narrow devices, it's visible on the screenshots in jira but not explicitly mentioned in text there or here, so i figured i should (i never used that button so i had no idea it was an issue until looking at the jira screenshots just now either...) |
|
@slavalamp Thanks for pointing that out! I've updated the issue so testers can confirm that's fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6737
Purpose
I told james_ to remove some styles in #4808 (AO3-6725) and I was wrong; when we removed them, the recent bookmarks on tag bookmark listings got too narrow and (in Low Vision Default) acquired all sorts of silly borders.
This puts that area back to the way it was.
Testing Instructions
Refer to Jira.
References
#4808 // This comment ft. me being wrong
#4825
#4846
AO3-6725
Credit
Sarken, she/her