AO3-6713 Enable comment moderation for admin posts #4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Allow admins to approve all comments on admin posts
…e with relative keyes and this is a code style fix
…this entire action
…code that we supposedly shouldn't need)
…when refactoring the create action
sarken
commented
Apr 15, 2024
Comment on lines
-371
to
-375
| else | ||
| # this shouldn't come up any more | ||
| flash[:comment_notice] = ts("Sorry, but this comment looks like spam to us.") | ||
| redirect_back_or_default(root_path) |
There was a problem hiding this comment.
I took this out (as well as the initial @comment.approved? check) because Reviewdog was really unhappy with the nesting here, and it had me making so many changes to this action that, hey, what's another one. We're just going to assume that if a comment is saved, it passed the spam check.
brianjaustin
requested changes
Apr 19, 2024
brianjaustin
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6713
Purpose
Adds comment moderation for admin posts.
Dreadfully sorry about not having the issue number in any of the commits; I merged with master before I thought to fix it. At least we squash now?
Testing Instructions
Refer to Jira.
Credit
Sarken, she/her