Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6706 Support Sentinel config for Redis clients #4787

Merged
merged 2 commits into from
May 17, 2024

Conversation

brianjaustin
Copy link
Member

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6706

Purpose

With some work I've done (and will do after this is merged) on the systems side, this will let us use Redis Sentinel to support automatic failovers when one Redis server becomes unavailable. This is better for High Availability and situations where we need to upgrade software/hardware.

For reviewers: I'd recommend turning whitespace diff off, since I made changes there to satisfy Rubocop.

Credit

Brian Austin (they/he)

Verified

This commit was signed with the committer’s verified signature.
brianjaustin Brian Austin
Copy link
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Sidenote, the example config in the code comment is invalid:

  • The docs show that name should be set in the redis options when using sentinels.
  • The port of the second sentinel is too high for a port number.

Verified

This commit was signed with the committer’s verified signature.
brianjaustin Brian Austin
@zz9pzza zz9pzza merged commit 2254624 into otwcode:master May 17, 2024
26 checks passed
@brianjaustin brianjaustin deleted the feat/redis-sentinel-support branch May 17, 2024 20:52
sarken added a commit that referenced this pull request May 31, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This reverts commit 2254624.
sarken added a commit that referenced this pull request May 31, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Revert "AO3-6706 Support Sentinel config for Redis clients (#4787)"

This reverts commit 2254624.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants