AO3-6703 Fix that some tests didn't run due to exit call in rake task #4780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjaustin
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6703
Purpose
In the
search:index_tagstest, rescue the SystemExit exception raised by theexitcall in the rake task, so that RSpec doesn't exit early.Testing Instructions
The issue is in automated testing, no manual QA needed.
The early exit caused a failed test on
masterinspec/lib/i18nto not get reported by GitHub Actions. It should get reported now, so the RSpec test should fail on this PR. No other test should fail. The i18n test itself is fixed in #4779.Credit
Bilka (he/him)