AO3-5053 Update bookmarker byline when pseud or username changes

[irrationalpie7]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-5053

Purpose

Updates bookmark blurbs when a bookmarker changes their username or pseud

Testing Instructions

See Jira.

References

I modeled some of my approach on https://otwarchive.atlassian.net/browse/AO3-4120

Credit

irrationalpie, they/them

[Bilka2]

The feature test error is happening because you switched from ts to t. The switch is great, t is preferred. But then the link to the user should be integrated into the translation call so it looks like t(".bookmarked_by_html", pseud_link: link_to(....)) and the translation needs to be in config/locales/views/en.yml, in this case in a new section for bookmarks:

bookmarks:
  bookmark_user_module:
    bookmarked_by_html: Bookmarked by %{pseud_link}

[Bilka2]

For context: Normally the tests would let you know that the translation for "Bookmarked by" is missing (in the yml file). The missing translation caused it to get converted to "Bookmarked By" in the feature tests. And the test for missing translations fails, as it should. However, the reporting for it on GitHub is broken, see https://otwarchive.atlassian.net/browse/AO3-6703.

I found what the issue was because I tried to look at the blurb in my local dev install and got the "translation missing" error there.