AO3-6696 Change reviewdog workflows to install only linter gems #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjaustin
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6696
Purpose
Use the
BUNDLE_ONLYenvironment variable to install only the linter gems in the reviewdog linter github action workflows. Installing less gems should hopefully speed up the workflows.Testing Instructions
No manual testing needed, simply see if it runs correctly on new PRs/pushes for PRs (including this PR). I tested it on my fork and the workflow was fine and reported the added errors: Bilka2#9
References
Based on the updated readme of action-rubocop which I found when reviewing #4766. However, this change is independent of the update of the action.
Credit
Bilka (he/him)