-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-6608 Delete Alt Text With Pseud Icon #4765
Merged
brianjaustin
merged 7 commits into
otwcode:master
from
smclairecarden:AO3-6608_deleteAltText
Apr 4, 2024
Merged
AO3-6608 Delete Alt Text With Pseud Icon #4765
brianjaustin
merged 7 commits into
otwcode:master
from
smclairecarden:AO3-6608_deleteAltText
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjaustin
requested changes
Mar 17, 2024
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Mar 18, 2024
brianjaustin
added
Reviewed: Action Needed
and removed
Coder Has Actioned Review
labels
Mar 18, 2024
brianjaustin
changed the title
AO3-6608 Delete Alt Text With Psued Icon
AO3-6608 Delete Alt Text With Pseud Icon
Mar 18, 2024
Co-authored-by: Brian Austin <13002992+brianjaustin@users.noreply.github.com>
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Mar 21, 2024
brianjaustin
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
brianjaustin
added
Reviewed: Ready to Merge
and removed
Coder Has Actioned Review
labels
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing
)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6608 (Please fill in issue number and remove this comment.)
Purpose
What does this PR do?
Delete alt text associated with a pseuds Icon when the icon is deleted.
Testing Instructions
How can the Archive's QA team verify that this is working as you intended?
If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.
see Jira!
References
Are there other relevant issues/pull requests/mailing list discussions?
Credit
Claire C she/her