Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6647 Fix paperclip with no paperclip patch #4761

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

zz9pzza
Copy link
Contributor

@zz9pzza zz9pzza commented Mar 2, 2024

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6647

Purpose

Fix a 500 error that occurs when trying to get the URL of an icon uploaded to s3:

3.1.4 :018 > begin
3.1.4 :019 >   u = User.where(login:"zz9pzza").first
3.1.4 :020 >   puts u.pseuds.first.icon.url
3.1.4 :021 > rescue => exception
3.1.4 :022 >   puts exception.backtrace
3.1.4 :023 >   raise # always reraise
3.1.4 :024 > end
/home/ao3app/.rvm/rubies/ruby-3.1.4/lib/ruby/3.1.0/psych.rb:322:in `safe_load'
/home/ao3app/app/shared/bundle/ruby/3.1.0/gems/kt-paperclip-7.1.0/lib/paperclip/storage/s3.rb:432:in `find_credentials'
/home/ao3app/app/shared/bundle/ruby/3.1.0/gems/kt-paperclip-7.1.0/lib/paperclip/storage/s3.rb:316:in `parse_credentials'
/home/ao3app/app/shared/bundle/ruby/3.1.0/gems/kt-paperclip-7.1.0/lib/paperclip/storage/s3.rb:198:in `s3_credentials'

Testing Instructions

How can the Archive's QA team verify that this is working as you intended?

If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.

References

Are there other relevant issues/pull requests/mailing list discussions?

Credit

What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?

If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.

Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.

@brianjaustin brianjaustin added the Has Production Config Changes Modifies the config file and needs special attention when deploying label Mar 2, 2024
Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noting that this will require Ansible changes as discussed elsewhere

@zz9pzza zz9pzza added the Priority: High - Broken on Test Merge immediately after approval label Mar 2, 2024
@sarken sarken merged commit 49285b4 into otwcode:master Mar 3, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Has Production Config Changes Modifies the config file and needs special attention when deploying Priority: High - Broken on Test Merge immediately after approval Reviewed: Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants