-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-6564 Reduce fields where images are shown #4729
Conversation
Just a heads up this has merge conflicts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, you know what just occurred to me: for news post comments, we should also be stripping the images from comment emails, both for the admin comment mailer and the user comment mailer.
Would you be up for making that change?
Sorry @sarken, I don't think I'll have the time for a while. |
No worries! Someone might push to your branch or open up a second PR with that change, though, since we'd like this for the next regular release after we update Ruby and Rails. |
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing
)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6564
Purpose
Strip images in the following:
Testing Instructions
See Jira issue.
Credit
weeklies (she/her)