Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6564 Reduce fields where images are shown #4729

Merged
merged 12 commits into from
Mar 24, 2024

Conversation

weeklies
Copy link
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6564

Purpose

Strip images in the following:

  • bookmarker notes
  • pseud descriptions
  • admin banners
  • comments on news posts
  • comment field on PAC and Support forms

Testing Instructions

See Jira issue.

Credit

weeklies (she/her)

app/views/comments/_single_comment.html.erb Show resolved Hide resolved
app/views/layouts/_banner.html.erb Outdated Show resolved Hide resolved
features/comments_and_kudos/add_comment.feature Outdated Show resolved Hide resolved
features/other_a/pseuds.feature Show resolved Hide resolved
@sarken
Copy link
Collaborator

sarken commented Feb 27, 2024

Just a heads up this has merge conflicts!

Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, you know what just occurred to me: for news post comments, we should also be stripping the images from comment emails, both for the admin comment mailer and the user comment mailer.

Would you be up for making that change?

@weeklies
Copy link
Contributor Author

Sorry @sarken, I don't think I'll have the time for a while.

@sarken
Copy link
Collaborator

sarken commented Feb 28, 2024

No worries! Someone might push to your branch or open up a second PR with that change, though, since we'd like this for the next regular release after we update Ruby and Rails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants