AO3-6017 Add role of commenter to comment notification emails #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceithir
reviewed
Dec 17, 2023
| style_link(comment.comment_owner_name, polymorphic_url(comment.comment_owner, only_path: false)) | ||
| role = comment.user.official ? t("roles.official_with_parens") : t("roles.registered_with_parens") | ||
| pseud_link = style_link(comment.pseud.byline, user_pseud_url(comment.user, comment.pseud)) | ||
| t("roles.commenter_name_html", name: style_bold(pseud_link), role: style_role(role)) | ||
| end | ||
| end |
There was a problem hiding this comment.
Not 100% sold myself, but might be more manageable with smaller scope if like:
if comment.by_anonymous_creator?
return style_bold(t("roles.anonymous_creator"))
end
name =
if comment.comment_owner.nil?
comment.comment_owner_name
else
style_link(comment.pseud.byline, user_pseud_url(comment.user, comment.pseud))
end
role =
if comment.comment_owner.nil?
t("roles.guest_with_parens")
elsif comment.user.official
t("roles.official_with_parens")
else
t("roles.registered_with_parens")
end
t("roles.commenter_name_html", name: style_bold(name), role: style_role(role))There was a problem hiding this comment.
I like the idea of turning the anon comment into a guard clause like
return style_bold(t("roles.anonymous_creator")) if comment.by_anonymous_creator?but I don't know about the rest of the conditions.
brianjaustin
requested changes
Feb 10, 2024
Co-authored-by: Brian Austin <13002992+brianjaustin@users.noreply.github.com>
Would have been nice if GitHub allowed me to do that in my browser
In text mails the indentation ends up in the emails, which is not desired
sarken
reviewed
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6017
Purpose
Adds the role of the commenter to comment notification emails. This marks logged-in users either as registered or official.
Add mailer previews for some comment notification emails, to cover all the different permutations of the pseud/user text (default pseud, different pseud, official, guest, anonymous creator).
Add tests for the commenter name display changes, including showing the username for comments left with pseuds and adding
(Guest)for guest commenters from AO3-6548.Testing Instructions
See Jira.
Credit
Bilka (he/him)