Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6647 Upgrade Ruby to 3.1.4 #4676

Merged
merged 10 commits into from
Feb 28, 2024
Merged

AO3-6647 Upgrade Ruby to 3.1.4 #4676

merged 10 commits into from
Feb 28, 2024

Conversation

zz9pzza
Copy link
Contributor

@zz9pzza zz9pzza commented Dec 1, 2023

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6647

Purpose

Change the version of ruby that the Archive uses.

Testing Instructions

I would do a smoke test

References

Are there other relevant issues/pull requests/mailing list discussions?

Credit

He/Him

@zz9pzza zz9pzza added Deferred or Superseded Should not be merged because it is waiting on more thought, another pull request, etc Has Production Config Changes Modifies the config file and needs special attention when deploying and removed Deferred or Superseded Should not be merged because it is waiting on more thought, another pull request, etc labels Dec 1, 2023
@zz9pzza
Copy link
Contributor Author

zz9pzza commented Dec 2, 2023

Need to check
WARNING: The monkeypatch /otwa/config/initializers/monkeypatches/mail_disable_starttls.rb was written for version 2.7.1 of the mail gem, but you are running 2.8.1. Please update or remove the monkeypatch.

@Bilka2
Copy link
Contributor

Bilka2 commented Dec 4, 2023

It may be good to update the parser gem to at least v3.2.2.0 to support ruby 3.1.4.

@Bilka2
Copy link
Contributor

Bilka2 commented Dec 10, 2023

The upgraded parser gem is missing from the commit. Rest looks good.

Gemfile.lock Outdated Show resolved Hide resolved
@brianjaustin brianjaustin requested a review from Bilka2 February 19, 2024 21:10
@sarken sarken changed the title AO3-6647 upgrade ruby to 3.1.X AO3-6647 Upgrade ruby to 3.1.4 Feb 28, 2024
@sarken sarken changed the title AO3-6647 Upgrade ruby to 3.1.4 AO3-6647 Upgrade Ruby to 3.1.4 Feb 28, 2024
@sarken sarken merged commit 9858bcf into otwcode:master Feb 28, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gem Updates Has Production Config Changes Modifies the config file and needs special attention when deploying Reviewed: Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants