-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-6647 Upgrade Ruby to 3.1.4 #4676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zz9pzza
added
Deferred or Superseded
Should not be merged because it is waiting on more thought, another pull request, etc
Has Production Config Changes
Modifies the config file and needs special attention when deploying
and removed
Deferred or Superseded
Should not be merged because it is waiting on more thought, another pull request, etc
labels
Dec 1, 2023
Need to check |
It may be good to update the parser gem to at least v3.2.2.0 to support ruby 3.1.4. |
The upgraded parser gem is missing from the commit. Rest looks good. |
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Feb 19, 2024
Bilka2
reviewed
Feb 19, 2024
Bilka2
approved these changes
Feb 19, 2024
brianjaustin
added
Reviewed: Ready to Merge
and removed
Coder Has Actioned Review
labels
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Gem Updates
Has Production Config Changes
Modifies the config file and needs special attention when deploying
Reviewed: Ready to Merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing
)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6647
Purpose
Change the version of ruby that the Archive uses.
Testing Instructions
I would do a smoke test
References
Are there other relevant issues/pull requests/mailing list discussions?
Credit
He/Him