AO3-6579 Set @page_title to Create Account not New Registration

[helpotters]

The heading in the New User Registrations page says "Create Account", however, the browser tab says "New Registration". In the controller's :new action, I added @page_title = 'Create Account' to make the browser tab match.

Note: This differs from setting @title, which would change the heading.

In regards to implementation, I tried following the note within the Jira issue:

This should be set in the new action of the Users::Registrations controller.

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-6579

Purpose

Match the browser tab @page_title with the Heading @title.

Testing Instructions

Note: Looking for confirmation in regards to how I set the variable. I used a normal string with 'Create Account', rather than pulling it from somewhere like @page_title = ts('New User Invitation Request'). Please confirm if this is okay.

• Allow for new Account Creation in development
  (I just temporarily removed if !AdminSetting.current.account_creation_enabled? in users/registrations_controller.rb#66.
• Go to the /signup path (127.0.0.1:3000/signup, depending on your setup).
• Check your browser tab and ensure that it says "Create Account" instead of "New Registration" (or (development) Create Account).

Credit

Paul Lemus (he/him)

[helpotters]

Resolved!
I'm also not on the volunteer team, so I don't have the Jira permissions to follow through on the After Submitting a PR.

Let me know if this is okay. It is currently still labeled as an open issue.

[sarken]

Hi, Paul!

Thank you so much for this pull request -- what you've done is just fine! Someone will be along to review it soon.

In the meantime, I've assigned the Jira issue to you and set its status to In Review, so no one will mistakenly create a duplicate pull request. I've also given your account permission to comment on, assign, and transition issues in the future.

Thanks again for contributing! If you have any questions, you can contact us at otw-coders@transformativeworks.org.