AO3-6646 Fix flaky works tests

features/step_definitions/web_steps.rb

@@ -270,6 +270,10 @@ def with_scope(locator)
   current_url.should include(url)
 end
 
+Then "the url should not include {string}" do |url|
+  expect(current_url).not_to include(url)
+end
+
 Then /^(?:|I )should have the following query string:$/ do |expected_pairs|
   query = URI.parse(current_url).query
   actual_params = query ? CGI.parse(query) : {}

features/step_definitions/work_steps.rb

@@ -694,6 +694,9 @@
 
 When "the cache for the work {string} is cleared" do |title|
   work = Work.find_by(title: title)
+
+  # Delay to force the updated_at that gets set by .touch to be new
+  step "it is currently 1 second from now"
   # Touch the work to actually expire the cache
   work.touch
 end

features/works/work_browse.feature

@@ -16,15 +16,20 @@ Scenario: If works in a listing exceed the maximum search result count,
     And 2 items are displayed per page
     And I am logged in
     And I post the work "Whatever 1" with fandom "Aggressive Retsuko"
+    # Ensure stable work order
+    And it is currently 1 second from now
     And I post the work "Whatever 2" with fandom "Aggressive Retsuko"
+    And it is currently 1 second from now
     And I post the work "Whatever 3" with fandom "Aggressive Retsuko"
+    And it is currently 1 second from now
     And I post the work "Whatever 4" with fandom "Aggressive Retsuko"
 
   When I browse the "Aggressive Retsuko" works with page parameter "2"
   Then I should see "3 - 4 of 4 Works"
     And I should not see "Please use the filters"
 
-  When I post the work "Whatever 5" with fandom "Aggressive Retsuko"
+  When it is currently 1 second from now
+    And I post the work "Whatever 5" with fandom "Aggressive Retsuko"
     And I browse the "Aggressive Retsuko" works
   Then I should see "1 - 2 of 5 Works"
     And I should not see "Please use the filters"

features/works/work_edit.feature

@@ -77,6 +77,8 @@ Feature: Edit Works
       And I follow "Edit"
       And I select "testy" from "work_author_attributes_ids"
       And I unselect "testuser" from "work_author_attributes_ids"
+      # Expire byline cache
+      And it is currently 1 second from now
       And I press "Post"
     Then I should see "testy"
       And I should not see "testuser,"

features/works/work_edit_multiple.feature

@@ -15,6 +15,7 @@ Feature: Edit Multiple Works
       And I should see "Edit Multiple Works"
     When I select "Glorious" for editing
       And I select "Excellent" for editing
+      And it is currently 1 second from now
       And I press "Delete"
     Then I should see "Are you sure you want to delete these works PERMANENTLY?"
       And I should see "Glorious"

features/works/work_share.feature

@@ -80,4 +80,6 @@ Feature: Share Works
       And I fill in "User name or email:" with "maduser"
       And I fill in "Password:" with "password"
       And I press "Log In"
-    Then I should be on the "Blabla" work page
+    Then the url should not include "share"
+      # Shown when the share url is accessed directly
+      And I should not see "Sorry, you need to have JavaScript enabled for this."