Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6636 Fixup speculation rules next-chapter prefetch #4667

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

domenic
Copy link
Contributor

@domenic domenic commented Nov 21, 2023

942f4a3 accidentally used the "eagerness" field, which is only supported in Chrome 121+. It isn't necessary in our case (the value we used, "eager", is already the default) so we can just remove it to fix prefetching in earlier versions of Chrome.

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6636

Purpose

Fixes the speculation rules prefetch feature to work on earlier Chrome versions.

Testing Instructions

See the Jira ticket

References

Credit

Domenic Denicola, he/him

942f4a3 accidentally used the "eagerness" field, which is only supported in Chrome 121+. It isn't necessary in our case (the value we used, "eager", is already the default) so we can just remove it to fix prefetching in earlier versions of Chrome.
@sarken sarken added the Priority: High - Broken on Test Merge immediately after approval label Nov 21, 2023
@sarken sarken merged commit 819c435 into otwcode:master Nov 21, 2023
@domenic domenic deleted the fixup-spec-rules branch November 21, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants