AO3-3866 update revised_at when a work is revealed #4664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeklies
reviewed
Nov 18, 2023
|
I thought the current plan is to re-do the whole thing instead? |
Yes, I'm aware of that. However, this issue was bothering my girlfriend (who has a long-running challenge that is affected by it) and I thought this might be a good quick fix; I'm not sure how long AO3-4546 might take to be implemented. But if this looks like adding technical debt and the maintainers don't want to do that, I would understand and we could cancel the PR. |
|
@eliahhecht I think we'd prefer to collapse the timestamp fields as described in the epic @EchoEkhi linked. I'm going to close this PR for now so it doesn't take 1 of your 5 slots, but feel free to continue discussing here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-3866 (Please fill in issue number and remove this comment.)
Purpose
When a work changes from unrevealed to revealed, update its revised_at date, so that it sorts according to when it was revealed, rather than when it was originally posted.
Testing Instructions
Testing instructions in the issue should confirm the fix.
Credit
Eliah Hecht, he/him