AO3-6632 Fix flaky collection anonymity tests #4660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6632
Purpose
Fix flaky collection anonymity tests by adding simulated delays before certain actions to ensure cache expiry and correct ordering of works sorted by age.
Testing Instructions
No manual QA required. I ran the test 50x here, with no failures. Before the fix, 50 runs resulted in a variety of failures, including in some tests in the same file that are not listed in the Jira issue. They are all fixed now.
References
sarken's WIP with email failure related to work ordering.
Credit
Bilka (he/him)