Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AO3-6601 Fix flaky orphan work tests #4656

Merged
merged 1 commit into from
Nov 13, 2023
Merged

AO3-6601 Fix flaky orphan work tests #4656

merged 1 commit into from
Nov 13, 2023

Conversation

Bilka2
Copy link
Contributor

@Bilka2 Bilka2 commented Nov 11, 2023 •
edited
Loading

Issue

https://otwarchive.atlassian.net/browse/AO3-6601

Purpose

Fix flaky orphan work tests by adding a simulated delay before orphaning. This means the cache is expired when orphaning and we don't get an intermittent failure.

Testing Instructions

No manual QA required. I ran the test 50x here (and them re-ran all of them once for good measure), with no failures. Only the "Scenario: I can orphan multiple works at once" semi-regularly failed for me in previous runs, so I am not completely sure that the other tests are no longer flaky. But as long as they're not failing, I'd say it's fine.

References

Fix and workflow to test the fix based on #4372.

Credit

Bilka (he/him)

@github-actions github-actions bot added Scope: Tests Only Only changes automated tests or test configuration Awaiting Review labels Nov 11, 2023
@ceithir ceithir mentioned this pull request Nov 11, 2023
Merged
5 tasks
ceithir added a commit to ceithir/otwarchive that referenced this pull request Nov 11, 2023
@ceithir
Fix another intermittent test
16d7380 
Inspired by otwcode#4656
@redsummernight redsummernight merged commit 1477313 into otwcode:master Nov 13, 2023
24 checks passed
@redsummernight redsummernight added this to the 0.9.352: Downloads milestone Nov 13, 2023
@Bilka2 Bilka2 deleted the AO3-6601-intermittent-failures-orphan-work-feature branch November 13, 2023 07:14
sarken pushed a commit that referenced this pull request Nov 15, 2023
@ceithir
AO3-6638 Intermittent failure in cucumber tag_wrangling, orphan_pseud…
bba3552 
…, and user_delete features (#4658)

* Fix grandfather flakiness

* Helpful (?) comment

* Fix another intermittent test

Inspired by #4656

* Alternative fix

More consistent with other formerly intermittent tests

* Fix more orphan tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redsummernight redsummernight redsummernight approved these changes

@ceithir ceithir ceithir approved these changes

Assignees
No one assigned
Labels
Reviewed: Ready to Merge Scope: Tests Only Only changes automated tests or test configuration
Projects
None yet
Milestone
0.9.352: Downloads
Development

Successfully merging this pull request may close these issues.
4 participants
@Bilka2 @ceithir @redsummernight @brianjaustin