-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-6526 Don't reveal if user is banned or suspended when inviting as co-creator #4563
Conversation
Heck yeah. All checks passed. Should be good for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two really minor comments -- otherwise, it looks good! Thanks for working on this.
Got slapped with covid and recovering. I'm still working on these changes and will work to get them updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to hear you got COVID! I hope the recovery process has been smooth. Just one last change, and maybe revert the app/models/work.rb
change to resolve the merge conflict, and then everything should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing
)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6526
Purpose
This PR does the following:
Invalid creator: testy_banned is currently banned and cannot be listed as a co-creator
toInvalid creator: testy_banned cannot be listed as a co-creator.
def check_disallowed
so that it also checks to see if the user is banned or suspended while they have co-creator on. This way if they are banned, it will just simply tell them that they cannot be invited as a co-creator.Testing Instructions
Ban or suspend a user
Log in as admin
Manage Users > Find Users
In “Name,” enter the name of the user you want to ban or suspend
Find
Follow the “Details” link
Under “Warnings and suspensions,” choose the desired option to ban or suspend
Fill in “Notes”
Update
Log out
Post a co-created work as the user who is not banned/suspended
Log in
Post > New Work
Fill in required info
Check “Add co-creators?”
Enter the name of the banned/suspended user
Post
References
There are no other known discussions or references that I have been able to find.
Credit
What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes? Ivedonestranger (he/him)
Jira Account: Jonathan S. (ivedonestranger)