Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6526 Don't reveal if user is banned or suspended when inviting as co-creator #4563

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

JonathanS223
Copy link
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6526

Purpose

This PR does the following:

  1. Invalid creator: testy_banned is currently banned and cannot be listed as a co-creator to Invalid creator: testy_banned cannot be listed as a co-creator.
  2. updated the function def check_disallowed so that it also checks to see if the user is banned or suspended while they have co-creator on. This way if they are banned, it will just simply tell them that they cannot be invited as a co-creator.

Testing Instructions

Ban or suspend a user
Log in as admin
Manage Users > Find Users
In “Name,” enter the name of the user you want to ban or suspend
Find
Follow the “Details” link
Under “Warnings and suspensions,” choose the desired option to ban or suspend
Fill in “Notes”
Update
Log out

Post a co-created work as the user who is not banned/suspended
Log in
Post > New Work
Fill in required info
Check “Add co-creators?”
Enter the name of the banned/suspended user
Post

References

There are no other known discussions or references that I have been able to find.

Credit

What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes? Ivedonestranger (he/him)

Jira Account: Jonathan S. (ivedonestranger)

@JonathanS223 JonathanS223 changed the title git commit -m "AO3-6526 fixed ban msg and flags" AO3-6526 fixed ban msg and flags Jul 5, 2023
@JonathanS223
Copy link
Contributor Author

Heck yeah. All checks passed. Should be good for review.

@sarken sarken changed the title AO3-6526 fixed ban msg and flags AO3-6526 Don't reveal if user is banned or suspended when inviting as co-creator Jul 6, 2023
Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two really minor comments -- otherwise, it looks good! Thanks for working on this.

app/models/creatorship.rb Outdated Show resolved Hide resolved
app/models/work.rb Outdated Show resolved Hide resolved
app/models/creatorship.rb Outdated Show resolved Hide resolved
@JonathanS223
Copy link
Contributor Author

Got slapped with covid and recovering. I'm still working on these changes and will work to get them updated.

Copy link
Contributor

@tickinginstant tickinginstant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to hear you got COVID! I hope the recovery process has been smooth. Just one last change, and maybe revert the app/models/work.rb change to resolve the merge conflict, and then everything should be good to go.

app/models/creatorship.rb Show resolved Hide resolved
app/models/creatorship.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@brianjaustin brianjaustin merged commit f67f428 into otwcode:master Feb 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants