AO3-3207 Fix incorrect work blurbs and meta when series is updated #4558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Expire cache of works when series is updated * Use right format for serialized JQuery data * Add tests
brianjaustin
requested changes
Jul 18, 2023
|
Sorry, I forgot about this earlier: could you bump the work blurb version cache key so we don't keep displaying the wrong thing for blurbs that are already cached? |
sarken
reviewed
Nov 29, 2023
| @@ -29,3 +29,31 @@ Feature: Rearrange works within a series | |||
| And I should see "1. A Bad, Bad Night" | |||
| And I should see "2. Things Get Worse" | |||
| And I should see "3. A Bad, Bad Day" | |||
|
|
|||
| @javascript | |||
| Scenario: Reordering series by drag and drop updates work blurbs correctly. | |||
There was a problem hiding this comment.
Support was asking about this issue and I'm a little confused -- is the issue with the blurb (the thing that appears on work index pages) or the meta (the thing that appears on the top of individual works)? The issue and pull request say the blurb, but the test appears to be checking the meta.
There was a problem hiding this comment.
This PR fixes both issues, I have edited the test to make sure the blurb is checked.
There was a problem hiding this comment.
Thanks for clarifying! I'll update the issue to make sure everything gets tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: I've added
.vscode/to.gitignore. Hope it's alright?)Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-3207
Purpose
Fix an issue when reordering series positions by drag and drop — this is caused by an incorrect datatype used in the AJAX request. Secondly, make the cache of works expire when a series is updated (especially when a new work is added to series).
Testing Instructions
See Jira issue and the past comment by Lady Oscar.
Credit
weeklies (she/her)
Huge thank you to ticking_instant and Bilka for answering my (beginner) questions on automated testing!