AO3-6307 Add mailer previews for creatorship notifications #4292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable mailer previews in development and staging. - Patch the preview UI to hide the ribbon dev mark. - To make the previews' locale selector work, move the I18n.with_locale block outside the mailer methods. - Wrap the previews in a transaction and roll back to avoid saving preview data to the database. - Use factory_bot to generate preview data. Simplify factory_bot setup. - In development and test, include factory_bot_rails which automatically finds and loads definitions. - In staging, install only factory_bot without loading it by default, because we don't want it used outside mailer previews where we explicitly require it.
sarken
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6307
Purpose
Enable mailer previews in development and staging.
I18n.with_localeblock outside the mailer methods.Simplify factory_bot setup.
Testing Instructions
The preview UI should be at https://test.archiveofourown.org/rails/mailers.