AO3-4842 Add <br /> between paragraphs for Support and PAC tickets #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 13, 2018
lib/html_cleaner.rb
Outdated
| @@ -398,4 +398,8 @@ def strip_html_breaks_simple(value) | |||
| strip | |||
| end | |||
|
|
|||
| def double_html_paragraphs(value) | |||
| return "" if value.blank? | |||
| value.gsub(/\s*<\/p>\s*<p>s*/, "</p><p> </p><p>") | |||
There was a problem hiding this comment.
Style/RegexpLiteral: Use %r around regular expression.
| @@ -20,6 +20,10 @@ def title | |||
| strip_html_breaks_simple(@title) | |||
| end | |||
|
|
|||
| def description | |||
There was a problem hiding this comment.
Lint/DuplicateMethods: Method FeedbackReporter#description is defined at both app/models/feedback_reporters/feedback_reporter.rb:5 and app/models/feedback_reporters/feedback_reporter.rb:23.
|
Looks good! 👍 Thank you for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-4842
Purpose
Adds a
<br />between the paragraphs in Support and PAC tickets because the ticket tracker's paragraph styling doesn't have margins, so the paragraphs looked more like:Paragraph 1
Paragraph 2
than like
Paragraph 1
Paragraph 2
even though they were correctly HTMLified as
<p>Paragraph 1</p><p>Paragraph 2</p>They are now rather horrifically done as
<p>Paragraph 1</p><br /><p>Paragraph 2</p>because a single empty<p></p>did not have sufficient line height to resemble a blank line, and or caused the tickets not to make it to the tracker, while an actual typed out space would get stripped and go right back to the line height not resembling a blank line.Testing
Refer to Jira