Skip to content

Commit

Permalink
AO3-6605 Add Reviewdog for Rubocop check (#4631)
Browse files Browse the repository at this point in the history
* AO3-6605 Add Reviewdog for Rubocop check

* Fix checkout version

* Remove rubocop from Hound

* Explicitly disable Hound

* Efficiency improvement

* Remove unneeded lines

---------

Co-authored-by: Bilka <Bilka2@users.noreply.github.com>
  • Loading branch information
brianjaustin and Bilka2 authored Nov 13, 2023
1 parent bd0f170 commit de957be
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
19 changes: 19 additions & 0 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,25 @@ permissions:
checks: write

jobs:
rubocop:
name: Rubocop
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v4

- name: Set up Ruby and run bundle install
uses: ruby/setup-ruby@v1
with:
bundler-cache: true

- name: rubocop
uses: reviewdog/action-rubocop@e70b014b8062c447d6b515ee0209f834ea93e696
with:
use_bundler: true
reporter: github-pr-check
skip_install: true

erb-lint:
name: ERB Lint runner
runs-on: ubuntu-latest
Expand Down
3 changes: 1 addition & 2 deletions .hound.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ jshint:
ignore_file: .jshintignore

rubocop:
version: 1.22.1
config_file: .rubocop.yml
enabled: false

0 comments on commit de957be

Please sign in to comment.