AO3-6626 test all forbidden characters

otwcode · Nov 20, 2023 · 2243127 · 2243127
1 parent 250b48f
commit 2243127
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/spec/models/tag_spec.rb b/spec/models/tag_spec.rb
@@ -49,7 +49,7 @@
         expect(@fandom_tag.taggings_count).to eq 1
       end
 
-      it 'will start caching a when tag when that tag is used significantly' do
+      it 'will start caching a tag when that tag is used significantly' do
         (1..ArchiveConfig.TAGGINGS_COUNT_MIN_CACHE_COUNT).each do |try|
           FactoryBot.create(:work, fandom_string: @fandom_tag.name)
           RedisJobSpawner.perform_now("TagCountUpdateJob")
@@ -168,11 +168,15 @@ def expect_tag_update_flag_in_redis_to_be(flag)
     expect(tag.errors[:name].join).to match(/too long/)
   end
 
-  it "should not be valid with disallowed characters" do
-    tag = Tag.new
-    tag.name = "bad<tag"
-    expect(tag.save).to be_falsey
-    expect(tag.errors[:name].join).to match(/restricted characters/)
+  context "tags using restricted characters should not be saved" do
+    BAD_TAGS.each do |tag|
+      forbidden_tag = Tag.new
+      forbidden_tag.name = tag 
+      it "is not saved and receives an error message about restricted characters" do
+        expect(forbidden_tag.save).to be_falsey
+        expect(forbidden_tag.errors[:name].join).to match(/restricted characters/)
+      end
+    end
   end
 
   context "unwrangleable" do

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -137,6 +137,7 @@
   config.use_transactional_fixtures = true
 
   BAD_EMAILS = ["Abc.example.com", "A@b@c@example.com", 'a\"b(c)d,e:f;g<h>i[j\k]l@example.com', 'this is"not\allowed@example.com', 'this\ still\"not/\/\allowed@example.com', "nodomain", "foo@oops", "ast*risk@example.com", "asterisk@ex*ample.com"].freeze
+  BAD_TAGS = [ "bad, tag", "also， bad", "no、good", "wild*card", "lesser<tag", "greater>tag", "^tag", "{open", "close}", "not=allowed", "suspicious`character", "no%maths" ]
   INVALID_URLS = %w[no_scheme.com ftp://ftp.address.com http://www.b@d!35.com https://www.b@d!35.com http://b@d!35.com https://www.b@d!35.com].freeze
   VALID_URLS = %w[http://rocksalt-recs.livejournal.com/196316.html https://rocksalt-recs.livejournal.com/196316.html].freeze
   INACTIVE_URLS = %w[https://www.iaminactive.com http://www.iaminactive.com https://iaminactive.com http://iaminactive.com].freeze