AO3-6895 Reduce the number of badly closed database connections #1689
reviewdog.yml
on: pull_request
Rubocop
1m 6s
ERB Lint runner
1m 36s
Annotations
1 error and 4 warnings
|
Rubocop
Process completed with exit code 1.
|
|
Rubocop:
app/jobs/redis_set_job.rb#L38
[rubocop] reported by reviewdog 🐶
Space missing inside {.
Raw Output:
app/jobs/redis_set_job.rb:38:40: C: Layout/SpaceInsideBlockBraces: Space missing inside {.
|
|
Rubocop:
app/jobs/redis_set_job.rb#L38
[rubocop] reported by reviewdog 🐶
Space missing inside }.
Raw Output:
app/jobs/redis_set_job.rb:38:80: C: Layout/SpaceInsideBlockBraces: Space missing inside }.
|
|
Rubocop:
lib/resque_executor_wrap.rb#L2
[rubocop] reported by reviewdog 🐶
Unused method argument - `args`. If it's necessary, use `_` or `_args` as an argument name to indicate that it won't be used. You can also write as `around_perform_wrap_executor(*)` if you want the method to accept any arguments but don't care about them.
Raw Output:
lib/resque_executor_wrap.rb:2:37: W: Lint/UnusedMethodArgument: Unused method argument - `args`. If it's necessary, use `_` or `_args` as an argument name to indicate that it won't be used. You can also write as `around_perform_wrap_executor(*)` if you want the method to accept any arguments but don't care about them.
|
|
Rubocop:
lib/resque_executor_wrap.rb#L3
[rubocop] reported by reviewdog 🐶
Consider using explicit block argument in the surrounding method's signature over `yield`.
Raw Output:
lib/resque_executor_wrap.rb:3:5: C: Style/ExplicitBlockArgument: Consider using explicit block argument in the surrounding method's signature over `yield`.
|