Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct nets_date converter #91

Merged
merged 4 commits into from
Aug 25, 2022
Merged

Correct nets_date converter #91

merged 4 commits into from
Aug 25, 2022

Conversation

sondrelg
Copy link
Contributor

@sondrelg sondrelg commented Aug 25, 2022

Accidentally switched from to_date_or_none to to_date in the v2 release. This switches it back.

Closes #90

This was the original behaviour before we refactored converters
for release v2
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 25, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.96 ⭐ 1.96 ⭐ 0.00
Method Length 64.00 🙂 63.99 🙂 -0.01 👍
Working memory 6.51 🙂 6.50 🙂 -0.01 👍
Quality 77.31% 77.31% 0.00%
Other metrics Before After Change
Lines 1398 1397 -1
Changed files Quality Before Quality After Quality Change
netsgiro/objects.py 76.97% ⭐ 76.97% ⭐ 0.00%
netsgiro/records.py 70.11% 🙂 70.12% 🙂 0.01% 👍
tests/test_object_building.py 55.75% 🙂 55.75% 🙂 0.00%
tests/test_record_parsing.py 87.95% ⭐ 87.95% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
netsgiro/records.py TransactionAmountItem2.to_ocr 13 🙂 169 😞 20 ⛔ 36.37% 😞 Try splitting into smaller methods. Extract out complex expressions
tests/test_object_building.py test_transmission_with_single_payment_request_transaction 0 ⭐ 336 ⛔ 13 😞 47.00% 😞 Try splitting into smaller methods. Extract out complex expressions
netsgiro/records.py AssignmentEnd.to_ocr 8 ⭐ 104 🙂 19 ⛔ 48.99% 😞 Extract out complex expressions
netsgiro/objects.py Assignment.from_records 7 ⭐ 149 😞 13 😞 50.93% 🙂 Try splitting into smaller methods. Extract out complex expressions
netsgiro/objects.py Transmission._get_end_record 11 🙂 119 🙂 10 😞 55.89% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sondrelg sondrelg force-pushed the fix-90 branch 2 times, most recently from 279d1c6 to 7344996 Compare August 25, 2022 08:41
@sondrelg sondrelg requested a review from klette August 25, 2022 08:48
@sondrelg sondrelg merged commit 7135320 into master Aug 25, 2022
@sondrelg sondrelg deleted the fix-90 branch August 25, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

parse a FBO file
1 participant