Move dependencies from peerDependencies to dependencies #5
Conversation
package.json
Outdated
| "peerDependencies": { | ||
| "@typescript-eslint/eslint-plugin": "^1.11.0", | ||
| "@typescript-eslint/parser": "^1.11.0", | ||
| "peerDependencies": {}, |
| 'error', | ||
| 'ignorePackages', | ||
| { | ||
| 'js': 'never', |
There was a problem hiding this comment.
I can't find it now but I remember reading the spec requires extensions for import. Any reason for disallowing extensions? What about ignoring the rule instead for now?
There was a problem hiding this comment.
Nice work! Keeping deps up to date is important and I appreciate you taking the time to do this 🙌
I tried this locally, and I had no issues with just upgrading the packages, but keeping them in peerDependencies 🤔 Maybe you encountered a different problem? Or is it because I don't have eslint installed globally?
After seeing and agreeing with @kmkr's comment, I suggest that you split your commit into 2 (or three):
Upgrade packagesMove from deps to peerDepstypescript: update import/extensions, and then add a rationale for why this was done 👍
I guess you could do 1 and 2 in one go – you decide :)
7f8e30c to
c522a9b
Compare
|
Upgraded all dependencies. Merging this now ✌️ Will publish to npm as soon as we're in master |
|
Thanks for dragging this across the finish line @rix1 ❤️ |
In Rainbow PR #21 I updated Rainbows dependencies. As part of that I upgraded ESLint from v5 to v6.
This change seemed to break the ESLint setup. The v6 migration guide seemed to indicate that plugins must be installed locally now. Thus, the dependencies was moved out of
peerDependenciesand intodependencies. This fixed my problem.I'm not quite sure about the implications of this change, though. Feedback (and alternative solutions) are greatly appreciated. 🙂