Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiled errors after upgrading openvino #35

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Fix compiled errors after upgrading openvino #35

merged 1 commit into from
Jun 2, 2020

Conversation

fujunwei
Copy link

@fujunwei fujunwei commented Jun 2, 2020

No description provided.

@fujunwei
Copy link
Author

fujunwei commented Jun 2, 2020

@huningxin PTAL, thanks.

huningxin
huningxin approved these changes Jun 2, 2020
View reviewed changes
Copy link

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix.

@huningxin huningxin merged commit 74a844d into otcshare:webml Jun 2, 2020
fujunwei pushed a commit that referenced this pull request Apr 22, 2022
Temporarily disable opening file:// on Android TM
3630083 
In Android TM for apps targeting API 33, READ_EXTERNAL_STORAGE is split
into specific permissions for READ_MEDIA_*. For now, skip requesting
READ_EXTERNAL_STORAGE when the user navigates to file:// URLs. Opening
the file:// will still fail, but the user won't first be prompted to
accept a permission that has no effect.

(cherry picked from commit 9501a42)

Bug: 1316672
Change-Id: I6fbcd6466f9ecda544712151bb3cdc2e04496897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3587279
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa Sullivan <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#993351}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3594606
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5005@{#35}
Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huningxin huningxin huningxin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fujunwei @huningxin