Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve optimal-quantifier-concatenation #279

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Improve optimal-quantifier-concatenation #279

merged 2 commits into from
Jul 28, 2021

Conversation

RunDevelopment
Copy link
Collaborator

This resolves #278.

This PR includes 2 things:

  1. Improved handling of quantifiers as described in Improve optimal-quantifier-concatenation #278.
  2. Support for nested quantifiers. In some case, we can simplify (or remove) a nested quantifier because of adjacent quantifiers (e.g. (?:\d+|foo)\w+ -> (?:\d|foo)\w+). This is essentially a generalization of the approach we already had.

@RunDevelopment RunDevelopment added the enhancement New feature or request label Jul 24, 2021
@RunDevelopment RunDevelopment requested a review from ota-meshi July 24, 2021 11:20
ota-meshi
ota-meshi approved these changes Jul 28, 2021
View reviewed changes
Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ota-meshi ota-meshi merged commit 6ea7524 into master Jul 28, 2021
@ota-meshi ota-meshi deleted the issue278 branch July 28, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve optimal-quantifier-concatenation
2 participants
@RunDevelopment @ota-meshi