Add sort-alternatives rule
#235
Merged
+565
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #214.
This adds the
sort-alternativesrule.I constrained the rule to only sort alternatives containing certain characters and non-star quantifiers. We might want to change these constraints in the future but they seem to be a good balance right now.
The implementation will be able to handle any change in constraints. Even without any constraints, it will still work correctly (= it won't sort alternatives if it changes the pattern) but the sorting might not make much sense (e.g. it will sort lists of punctuation characters).
One important note: numbers get special treatments. List (and sublists) containing only numbers will be sorted by value and not lexicographically. E.g.
3|5|16|1|32will be sorted as1|3|5|16|32and not1|16|3|32|5.