Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Drop support for Node.js<v18.18 #355

Merged
merged 2 commits into from
Apr 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/happy-mayflies-swim.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-astro": major
---

feat!: Drop support for Node.js<v18.18
2 changes: 1 addition & 1 deletion .github/workflows/GHPages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- uses: actions/setup-node@v4
- name: Install And Build
run: |+
npm install --legacy-peer-deps
npm install -f
npm run update
npm run build
export NODE_OPTIONS="--max-old-space-size=8192"
Expand Down
60 changes: 10 additions & 50 deletions .github/workflows/NodeCI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
- name: Install Packages
run: npm install --legacy-peer-deps
run: npm install -f
- name: build
run: |
npm run build
Expand All @@ -29,7 +27,7 @@ jobs:
- uses: actions/setup-node@v4
- name: Install And Build
run: |+
npm install --legacy-peer-deps
npm install -f
npm run update
npm run build
export NODE_OPTIONS="--max-old-space-size=8192"
Expand All @@ -38,15 +36,15 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [18.x, 20.x, 22.x]
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install Packages
run: npm install --legacy-peer-deps
run: npm install -f
- name: Test
run: npm test
test-for-eslint-v9:
Expand All @@ -57,17 +55,17 @@ jobs:
uses: actions/setup-node@v4
- name: Install eslint v9
run: |+
npm i -D eslint@^9.0.0-0 --legacy-peer-deps
npm i -D eslint@^9.0.0 -f
npx rimraf node_modules
- name: Install Packages
run: npm install --legacy-peer-deps
run: npm install -f
- name: Test
run: npm test
test-for-eslint-v7:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x]
node-version: [18.x]
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
Expand All @@ -76,45 +74,7 @@ jobs:
node-version: ${{ matrix.node-version }}
- name: Install eslint v7
run: |+
npm i -D eslint@7 @typescript-eslint/parser@5 --legacy-peer-deps
npx rimraf node_modules
- name: Install Packages
run: npm install --legacy-peer-deps
- name: Test
run: npm test
test-for-node-v14:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x]
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install @typescript-eslint/parser v5
run: |+
npm i -D @typescript-eslint/parser@5 eslint@8 -f
npx rimraf node_modules
- name: Install Packages
run: npm install -f
- name: Test
run: npm test
test-for-node-v16:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x]
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install eslint v8
run: |+
npm i -D eslint@8 -f
npm i -D eslint@7 @typescript-eslint/parser@5 -f
npx rimraf node_modules
- name: Install Packages
run: npm install -f
Expand All @@ -126,10 +86,10 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- name: Install Packages
run: npm install --legacy-peer-deps
run: npm install -f
- name: Test
run: npm run cover
- name: Coveralls GitHub Action
uses: coverallsapp/github-action@3dfc5567390f6fa9267c0ee9c251e4c8c3f18949 # v2.2.3
uses: coverallsapp/github-action@v2.2.3
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
- name: Install deps
run: npm install
run: npm install -f
- name: Format
run: npm run eslint-fix
- name: Commit
Expand Down
Loading
Loading