Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remount: Also run Before=systemd-hwdb-update.service #2104

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

I saw a race with the readonly sysroot with RHEL CoreOS because
we hadn't mounted /etc writable by the time systemd-hwdb-update.service
ran.

I saw a race with the readonly sysroot with RHEL CoreOS because
we hadn't mounted `/etc` writable by the time `systemd-hwdb-update.service`
ran.
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Member Author

One thing I'm not remembering here is why we don't just do all of ostree-remount in the initramfs. Or at least, if the rootfs is already writable, there's no reason to wait.

@cgwalters
Copy link
Member Author

Oh right, it's because ostree-prepare-root.c doesn't link to glib today. It's not at all a problem for those of us shipping an initramfs to do so, but is more of a problem for the no-initramfs statically-linked crowd.

Hmm. I guess we could use a kernel argument, or honestly just don't use GKeyFile and just read the config line by line.

@akiernan
Copy link
Contributor

It's not at all a problem for those of us shipping an initramfs to do so, but is more of a problem for the no-initramfs statically-linked crowd.

/me raises hand!

I guess my only concern with a kernel argument is ensuring it gets in there on upgrade, if folk are hardcoding their boot parameters.

@jlebon
Copy link
Member

jlebon commented May 20, 2020

Hmm, interesting, this is causing Kola failures. E.g.:

--- FAIL: ostree.remote (150.79s)
        harness.go:779: Cluster failed starting machines: machine "3bd322f2-eaff-4351-8594-c8020baa67f3" failed basic checks: some systemd units failed:
systemd-udev-settle.service loaded failed failed udev Wait for Complete Device Initialization

@cgwalters
Copy link
Member Author

Obsoleted by #2113

@cgwalters cgwalters closed this May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants