This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
Export full CLI in library #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ultimately I think it will work best if we fully encapsulate `ostree-ext-cli` in `rpm-ostree` in the short term. There's a strong tension in having two binaries. It *logically* makes sense, but logistically is harder (duplicating CI, documentation, crate dependency management, etc.) Keep the `cli` crate for now, but move all of the functionality of it into a simple `run_from_iter()` function that can be called by projects like rpm-ostree.
|
Rebased 🏄 |
travier
approved these changes
May 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export full CLI in library
Ultimately I think it will work best if we fully encapsulate
ostree-ext-cliinrpm-ostreein the short term. There'sa strong tension in having two binaries. It logically makes
sense, but logistically is harder (duplicating CI, documentation,
crate dependency management, etc.)
Keep the
clicrate for now, but move all of the functionalityof it into a simple
run_from_iter()function that can be calledby projects like rpm-ostree.