[Ellipsis] feat: add env vars for sc-server host and port configuration #456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses review comments left by @NikitaZotov on PR #453: **[tools][server] Environment variables for sc-server host and port **
Summary:
Add environment variables
SC_SERVER_HOST
andSC_SERVER_PORT
for sc-server configuration and update related documentation and logging.Key points:
SC_SERVER_HOST
andSC_SERVER_PORT
to configure sc-server host and port indocker-compose.yml
andsc_server_module.cpp
.changelog.md
andsc_machine.md
to include new environment variables.sc_machine_runner.cpp
to include new environment variables.sc_server.cpp
.You can configure Ellipsis to address comments with a direct commit or a side PR, see docs.
Something look wrong? If this Pull Request doesn't address the comments left on the above pull request, create a new PR review with more details. For more information, check the documentation.
Generated with ❤️ by ellipsis.dev