Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ellipsis] feat: add SC_SERVER_HOST and SC_SERVER_PORT environment variables for sc-server configuration #454

Closed
wants to merge 5 commits into from

Conversation

ellipsis-dev[bot]
Copy link

@ellipsis-dev ellipsis-dev bot commented Jan 14, 2025

This change addresses review comments left by @NikitaZotov on PR #453: **[tools][server] Environment variables for sc-server host and port **

⚠️ We couldn't build/test your project to verify our changes. Add a Dockerfile to significantly improve code quality.

Summary:

Add environment variables SC_SERVER_HOST and SC_SERVER_PORT for sc-server configuration and update documentation and logs accordingly.

Key points:

  • Environment Variables:
    • Add SC_SERVER_HOST and SC_SERVER_PORT to configure sc-server host and port in docker-compose.yml, sc_machine_runner.cpp, and sc_server_module.cpp.
  • Documentation:
    • Update changelog.md and sc_machine.md to include new environment variables.
  • Logging:
    • Change log message from "Host name" to "Host" in sc_server.cpp.

You can configure Ellipsis to address comments with a direct commit or a side PR, see docs.


Something look wrong? If this Pull Request doesn't address the comments left on the above pull request, create a new PR review with more details. For more information, check the documentation.

Generated with ❤️ by ellipsis.dev

@ellipsis-dev ellipsis-dev bot requested a review from NikitaZotov January 14, 2025 14:25
@NikitaZotov NikitaZotov deleted the ellipsis/jrun_W11SCIYRDuRPLiMG_5SXf branch January 15, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant