Skip to content

Commit

Permalink
Remove a wrong test not to slow down test262-es2015
Browse files Browse the repository at this point in the history
Since ES2018 iterator's next method is called once during the prologue of iteration,
rather than during each step. The test is incorrect and stuck in an infinite loop.
tc39/test262#1248 fixed the test and it passes on test262-esnext.

Removing test/language/statements/for-of/iterator-next-reference.js from test262-es2015
is necessary, because it won't pass ever and only slow down testing.

JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác csaba.osztrogonac@h-lab.eu
  • Loading branch information
ossy-szeged committed Jan 26, 2021
1 parent b8a0ffd commit a371a61
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions tools/runners/run-test-suite-test262.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,15 @@ def prepare_test262_test_suite(args):
if os.path.isdir(path_to_remove):
shutil.rmtree(path_to_remove)

# Since ES2018 iterator's next method is called once during the prologue of iteration,
# rather than during each step. The test is incorrect and stuck in an infinite loop.
# https://github.com/tc39/test262/pull/1248 fixed the test and it passes on test262-esnext.
if args.es2015:
test_to_remove = 'test/language/statements/for-of/iterator-next-reference.js'
path_to_remove = os.path.join(args.test_dir, os.path.normpath(test_to_remove))
if os.path.isfile(path_to_remove):
os.remove(path_to_remove)

return 0


Expand Down

0 comments on commit a371a61

Please sign in to comment.