Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More clearly distinguish -Werror with and without selectors #345

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

david-a-wheeler
Copy link
Contributor

It's fine to use -Werror with selectors that shouldn't ever occur. The problem is -Werror without selectors.
Modify the text to clearly distinguish these two cases.

It's *fine* to use -Werror with selectors that shouldn't ever
occur. The problem is -Werror without selectors.
Modify the text to clearly distinguish these two cases.

Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
…o -Werror variants

Streamline the text with the additions by re-ordering the synopsys.

Signed-off-by: Thomas Nyman <thomas.nyman@ericsson.com>
@thomasnyman thomasnyman force-pushed the selective-werror-okay branch from 9c5d15a to be2c8b1 Compare January 17, 2024 11:44
@thomasnyman
Copy link
Contributor

Made the additions consistently use 'blanket form' and 'selective form' when referring to the -Werror variants and streamlined the text in the synopsis by reordering the existing paragraphs to avoid some repetition.

@david-a-wheeler david-a-wheeler merged commit b22e645 into main Jan 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants