Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threat model, goals, objectives #317

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Add threat model, goals, objectives #317

merged 4 commits into from
Jan 17, 2024

Conversation

david-a-wheeler
Copy link
Contributor

These are hinted at, but they should be clearly stated. This will make it much easier to justify the options below (including future options).

These are hinted at, but they should be clearly stated.
This will make it much easier to justify the options below
(including future options).

Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
@thomasnyman
Copy link
Contributor

I think this should be introduced together with changes that address #283. I would also expect mitigating memory-safety issues to be mentioned in the threat model. I would argue that is a more obvious use of the guide, but I don't have any objections for addressing underhanded code too in the threat model.

@david-a-wheeler
Copy link
Contributor Author

thomasnyman:

I think this should be introduced together with changes that address #283.

With respect, I think this needs to be added first. First, we need to make sure people understand the goals - otherwise it's not obvious why changes support the goals.

I would also expect mitigating memory-safety issues to be mentioned in the threat model. I would argue that is a more obvious use of the guide, but I don't have any objections for addressing underhanded code too in the threat model.

That's a good idea. I think I can add a sentence at the end of a paragraph to make that clear without adding a lot of text.

Per review by @thomasnyman - tweak the proposed threat model text to
specifically note memory safety. It's a key point, and many readers
would probably expect us to mention the issue here.

Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
@david-a-wheeler
Copy link
Contributor Author

thomasnyman - I've added a sentence to expressly note the importance of memory safety. I made a few minor tweaks in this section since I was there anyway.

@david-a-wheeler
Copy link
Contributor Author

Note: I view this PR as a blocker for #283 . Until we agree on the threat model we're supporting, it's hard to determine whether or not some specific flags are relevant.

@thomasnyman
Copy link
Contributor

Turned inline links into references in footnotes to be consistent with the established style.

Signed-off-by: Thomas Nyman <thomas.nyman@ericsson.com>
@thomasnyman
Copy link
Contributor

Fixed broken link to Wikipedia article introduced in 6dff9b8

@david-a-wheeler david-a-wheeler merged commit 2084b79 into main Jan 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants