Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should start to count at 001 instead of 000 #240

Closed
FanJups opened this issue May 1, 2023 · 0 comments · Fixed by #266
Closed

Should start to count at 001 instead of 000 #240

FanJups opened this issue May 1, 2023 · 0 comments · Fixed by #266
Labels
done This ticket is solved jsgenerator-core core module

Comments

@FanJups
Copy link
Member

FanJups commented May 1, 2023

Its better for readability, we directly get the number of occurences
@FanJups FanJups added jsgenerator-core core module todo Ticket that has to be done labels May 1, 2023
This was referenced May 1, 2023
Closed
Open
@FanJups FanJups changed the title Start to count at 001 not 000 Should start to count at 001 instead of 000 May 6, 2023
FanJups added a commit to FanJups/js-generator that referenced this issue Mar 3, 2024
@FanJups
update: Issue osscameroon#240 updating the counter initial value from…
8b794a2 
… 0 to 1
@FanJups FanJups mentioned this issue Mar 3, 2024
Closed
FanJups added a commit to FanJups/js-generator that referenced this issue Mar 3, 2024
@FanJups
update: Issue osscameroon#240 updating the counter initial value from…
b748522 
… 0 to 1
FanJups added a commit to FanJups/js-generator that referenced this issue Mar 5, 2024
@FanJups
update: Issue osscameroon#240 updating the counter initial value from…
aa804c1 
… 0 to 1 - PR osscameroon#264  workflow bug
@FanJups FanJups mentioned this issue Mar 5, 2024
Merged
FanJups added a commit to FanJups/js-generator that referenced this issue Mar 5, 2024
@FanJups
update: Issue osscameroon#240 updating the counter initial value from…
9add7fb 
… 0 to 1 - PR osscameroon#264  workflow bug
FanJups added a commit to FanJups/js-generator that referenced this issue Mar 5, 2024
@FanJups
update: Issue osscameroon#240 updating the counter initial value from…
b44d612 
… 0 to 1
FanJups added a commit to FanJups/js-generator that referenced this issue Mar 5, 2024
@FanJups
update: Issue osscameroon#240 updating the counter initial value from…
20d6887 
… 0 to 1 - PR osscameroon#264  workflow bug
@FanJups FanJups added work in progress At least one person is currently working on this ticket and removed todo Ticket that has to be done labels Mar 5, 2024
FanJups added a commit to FanJups/js-generator that referenced this issue Mar 9, 2024
@FanJups
update: Issue osscameroon#240 updating the counter initial value from…
2a34d0e 
… 0 to 1 - PR osscameroon#264  workflow bug
FanJups added a commit that referenced this issue Mar 17, 2024
@FanJups
update: Issue #240 updating the counter initial value from 0 to 1 - PR …
5518929 
…#264  workflow bug (#266)

* update: Issue #240 updating the counter initial value from 0 to 1 - PR  #264  workflow bug

* trying to make test fail

* Undo "trying to make test fail"

* undo changes

* update:  resolves #267 trigger the Javadoc Workflow only if .github/workflows/javadoc.yml, jsgenerator-core/ or pom.xml has changed

* docs: delete the title's full stop

* update: Issue #240 updating the counter initial value from 0 to 1 - PR  #264  workflow bug

* trying to make test fail

* Undo "trying to make test fail"

* undo changes

* fix: fix tests on jsgenerator-core

* fix: fix tests on jsgenerator-api
@FanJups FanJups added done This ticket is solved and removed work in progress At least one person is currently working on this ticket labels Mar 17, 2024
FanJups added a commit that referenced this issue Jul 29, 2024
@FanJups
docs: update CLI docs with feature related to #240 and querySelector …
cc89864 
…option
FanJups added a commit that referenced this issue Sep 23, 2024
@SalathielGenese @FanJups
feat: #250 migrate from spring boot 2.7.3 to 3.3.1 and #269 update pi…
11857a0 
…peline from java 17 to 21 (#271)

* feat: upgrade to Spring Boot 3.3.1, Java from 17 to 21, get rid of Lombok, improve Java code

* feat: nor arg ends up like --help arg

* chore: from java 17 to 21

* chore: from java 17 to 21

* chore: delete unused dependencies spring-framework-bom 5.3.22 & spring-cloud-dependencies 2021.0.4

* docs: Update doc after migrating to Java 21 and Spring Boot 3.3.1

* docs: delete graalvm section and update readme

* refactor: delete wildcard imports

* fix: scan core package to get beans

* fix: correct API tests by preventing bean methods to be proxied

* docs: update CLI docs with feature related to  #240 and querySelector option

* fix: API & Desktop spring boot autoconf

* docs: update API example

* feat: add jsgenerator-desktop banner

* docs: Add jsgenerator-desktop documentation

* docs: update jsgenerator-cli example's command with the current version

* refactoring: delete double columns before jsgenerator-cli launch command

* docs: update API documentation with curl

* docs: delete colon before jsgenerator-cli launch command

* docs: update API documentation with curl

* ci: Prevent Maven github action to run when changing Markdown files

* fix: Correct Swagger dependency not working with Spring Boot 3

---------

Co-authored-by: Fanon Jupkwo <jupsfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done This ticket is solved jsgenerator-core core module
Projects
None yet
Milestone
No milestone
1 participant
@FanJups