Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix permissions on deploy + add author #24

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

Sanix-Darker
Copy link
Member

@Sanix-Darker Sanix-Darker commented Apr 2, 2024

WHAT

  • permissions: write-all to fix the permission for the staging deploy.
  • add sanix-darker as a new author.

WHY

may fix (#23)

@Sanix-Darker Sanix-Darker self-assigned this Apr 2, 2024
@Sanix-Darker Sanix-Darker marked this pull request as ready for review April 2, 2024 12:40
@Sanix-Darker Sanix-Darker requested review from tericcabrel and RMPR April 2, 2024 12:40
permissions:
contents: read
packages: write
permissions: write-all
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@RMPR RMPR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay, it won't be abused because new contributors still need approval before their jobs run right?

@Sanix-Darker
Copy link
Member Author

new contributors still need approval before their jobs run right?

normally yes !

@tericcabrel tericcabrel merged commit e80af20 into main Apr 2, 2024
1 check passed
@tericcabrel tericcabrel deleted the f/add-author branch April 2, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants