Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cocoapods): Add some logging to ease debugging #9708

Closed
wants to merge 1 commit into from

Conversation

sschuberth
Copy link
Member

No description provided.

@sschuberth sschuberth requested a review from a team as a code owner January 8, 2025 12:32
@sschuberth sschuberth enabled auto-merge (rebase) January 8, 2025 12:33
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.11%. Comparing base (1ffe4df) to head (c543bb5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9708   +/-   ##
=========================================
  Coverage     68.11%   68.11%           
  Complexity     1294     1294           
=========================================
  Files           249      249           
  Lines          8843     8843           
  Branches        922      922           
=========================================
  Hits           6023     6023           
  Misses         2432     2432           
  Partials        388      388           
Flag Coverage Δ
funTest-non-docker 33.30% <ø> (ø)
test-ubuntu-24.04 35.90% <ø> (ø)
test-windows-2022 35.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
@sschuberth sschuberth changed the title chore(cocoapods): Add some more logging to ease debugging chore(cocoapods): Add some logging to ease debugging Jan 8, 2025
Copy link
Member

@tsteenbe tsteenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of adding these log message to just CocaoPods manager and not others .. imo it makes more sense to print this out foreach found manager, maybe at the end of Analyzer log?

@sschuberth
Copy link
Member Author

Not a fan of adding these log message to just CocaoPods manager and not others .. imo it makes more sense to print this out foreach found manager, maybe at the end of Analyzer log?

In this case, these are Cocoapods-lockfile-specific low-level logs that helped me debugging stuff that would prevent the Cocoapods analyzer to even complete successfully. They're not meant to log general statistics that would apply to any package manager. I can either lower the log level to debug or drop the commit at your preference.

@sschuberth
Copy link
Member Author

I can either lower the log level to debug or drop the commit at your preference.

I decided to just drop this.

@sschuberth sschuberth closed this Jan 8, 2025
auto-merge was automatically disabled January 8, 2025 15:10

Pull request was closed

@sschuberth sschuberth deleted the cocoapods-imps branch January 8, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants