Revert "chore(stack)!: Temporarily disable Stack in Dockerfile-legacy and tests" #7697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7567fba to
7a63ef3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7697 +/- ##
=========================================
Coverage 66.96% 66.96%
Complexity 2041 2041
=========================================
Files 356 356
Lines 17084 17084
Branches 2443 2443
=========================================
Hits 11440 11440
Misses 4623 4623
Partials 1021 1021
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7a63ef3 to
b6f5878
Compare
|
BTW, should we use "revert:" as a conventional commit type for such commits? |
b6f5878 to
ca73460
Compare
… and tests" This reverts commit fc77b1c. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
ca73460 to
1ca663e
Compare
Apparently we also accept Git's generated "Revert ..." wording: Line 10 in a9bd271 |
sschuberth
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if just disabling
PubFunTestin #7694 would have been enough.