Add support for ScanCode output format version 3 #7397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5528e49 to
11fbc35
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7397 +/- ##
=========================================
Coverage 60.93% 60.93%
Complexity 1969 1969
=========================================
Files 338 338
Lines 16626 16626
Branches 2363 2363
=========================================
Hits 10131 10131
Misses 5517 5517
Partials 978 978
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Edit: @mnonnenmacher and myself discussed a work-around. |
11fbc35 to
a41b81d
Compare
Closed
a41b81d to
846c611
Compare
mnonnenmacher
requested changes
Sep 1, 2023
Make the mapping code operate directly on strings to prepare for a ScanCode data model refactoring. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
License reference information has been excluded by default from the result [1]. As that information is required to map ScanCode license keys to SPDX IDs [2], explicitly enable that option. [1]: aboutcode-org/scancode-toolkit@84eda21 [2]: aboutcode-org/scancode-toolkit#3458 Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
846c611 to
606bd5f
Compare
While in previous output formats the primary elements for license entries were single license keys (which needed to be grouped to expressions), starting with output format version 3 the primary license entries are expressions. Resolves #6617. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
606bd5f to
21b4266
Compare
mnonnenmacher
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.