Refactor the scanner API to support reading more than ScanCode results from ClearlyDefined #7242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d26c8fd to
63fdf5e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7242 +/- ##
============================================
- Coverage 61.47% 61.44% -0.03%
- Complexity 1966 1968 +2
============================================
Files 333 334 +1
Lines 16489 16504 +15
Branches 2355 2354 -1
============================================
+ Hits 10136 10141 +5
- Misses 5375 5385 +10
Partials 978 978
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
63fdf5e to
bd7b39c
Compare
fviernau
requested changes
Jul 6, 2023
Move `getVersion()` next to `getVersionRequirement()` for a better overview. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
This is a prerequisite for decoupling from concrete scanner / parser implementations and solely relying on the scanner plugin API. The idea is to later only take results from scan storages whose scanners are present as plugins. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
bd7b39c to
ecfa969
Compare
Usually, ScanCode scanner details are obtained from running the ScanCode CLI command. The only scenario where this is not possible is when retrieving ScanCode scan results from a scan storage. So, move the relevant code to storage specific utilities. While at it, give the functions more specific names. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Fields except for "_metadata" returned by `harvestToolData()` are tool-specific and should only be parsed by tool-specific code. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
…nners Filter the tool results from ClearlyDefined by the scanners ORT has available as a plugin and create a `ScanSummary` with the respective scanner plugin's function. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
ecfa969 to
2c0a890
Compare
fviernau
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.