Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider merging TestData.kt from evaluator, model and reporter #2842

Closed
sschuberth opened this issue Jul 8, 2020 · 2 comments
Closed

Consider merging TestData.kt from evaluator, model and reporter #2842

sschuberth opened this issue Jul 8, 2020 · 2 comments
Labels
enhancement Issues that are considered to be enhancements evaluator About the evaluator tool model About the data model reporter About the reporter tool

Comments

@sschuberth
Copy link
Member

sschuberth commented Jul 8, 2020 •
edited
Loading

As mentioned in 0f26841, the files

should probably be combined and / or rewritten using the OrtResultDsl for a better overview and code reuse.
@sschuberth sschuberth added enhancement Issues that are considered to be enhancements evaluator About the evaluator tool reporter About the reporter tool labels Jul 8, 2020
@sschuberth sschuberth added the model About the data model label Oct 24, 2022
@sschuberth sschuberth changed the title Consider merging TestData.kt from evaluator and reporter Consider merging TestData.kt from evaluator, model and reporter Oct 24, 2022
@sschuberth sschuberth mentioned this issue Oct 24, 2022
Closed
@sschuberth
Copy link
Member Author

By now, maybe netter replace all with usages of https://github.com/oss-review-toolkit/ort/blob/main/utils/test/src/main/kotlin/OrtResultDsl.kt.

@sschuberth sschuberth mentioned this issue Jun 23, 2023
Merged
@sschuberth
Copy link
Member Author

Closed as part of backlog grooming. Feel free to comment if you would like to contribute to this.

@sschuberth sschuberth closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issues that are considered to be enhancements evaluator About the evaluator tool model About the data model reporter About the reporter tool
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sschuberth