-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReporterTests: Create / use a minimal test asset covering all important cases #2287
Comments
Is this still true now that I see that #2286 did need to also update expected test results for the NOTICE-BY-PACKAGE reporter? |
Thanks, I've updated the description accordingly. |
I believe we have that by now in https://github.com/oss-review-toolkit/ort/blob/3832de6b085db813797df95e62bb6e8d8e2e2ce0/reporter/src/funTest/kotlin/TestData.kt. |
Reopening because @mnonnenmacher says:
|
This is somewhat related to #2842. |
This is also related to #5991, as an abstraction for the |
Closed as part of backlog grooming. Feel free to comment if you would like to contribute to this. |
The rather higher level tests for the reporters lack coverage for actually quite important cases. E.g. the
NoticeSummaryReporter
does not cover path excludes. Further the tests use test assets shared with other test so that they cannot be easily adjusted.Let's create on test asset which covers all cases relevant test cases for reporters and use for all the reporter tests to get more meaningful test and a better use case coverage.
The text was updated successfully, but these errors were encountered: