-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a global synchronized wavefield #598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@M1chaelM , as we discussed offline, I've created a |
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
M1chaelM
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564 using Gazebo Transport.
Before this patch, all the plugins using a wave field needed to have the same
<wavefield>
SDF parameter block in its SDF plugin definition. This pull request changes this behavior by:primary
. Theprimary
plugin requires to specify all the<wavefield>
parameters as usual. Then, it should periodically publish the wavefield parameters via Transport.secondary
. This means passing only one parameters inside the<wavefield>
block. This parameters is the topic name where the wave field parameters are sent. When received, the wavefield can be populated with a new helper function.Our
WaveVisual
plugin is set to operate as the primary. All the instances ofSurface
andPolyhedreaBuoyancyDrag
plugins are set to operate as secondary.How to test it?
and verify that the buoys and the WAM-V move a bit up and down.
vrx_gz/worlds/stationkeeping_task.sdf
:Recompile and launch the simulation again. You should verify now that the WAM-V and the buoys stay flat at the water surface.
[Edit: updated test instructions]