Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pinger bearing #427

Closed
wants to merge 8 commits into from
Closed

Fixed pinger bearing #427

wants to merge 8 commits into from

Conversation

andrew-aj
Copy link
Contributor

Fixed issue #426

@acxz
Copy link

acxz commented Jul 13, 2022

@M1chaelM @caguero can you take a quick look at this?

@M1chaelM
Copy link
Collaborator

@j-herman @caguero Following the discussion in #426, it looks like we decided not to make this change and instead document the convention we're using here, so I'm closing this PR. Please re-open if I've misunderstood.

@M1chaelM M1chaelM closed this Jul 26, 2022
@acxz
Copy link

acxz commented Jul 26, 2022

@M1chaelM can you just quickly update the wiki with the change?

@j-herman
Copy link
Collaborator

@M1chaelM can you just quickly update the wiki with the change?

I added some clarification to the wiki - please let me know if it's not clear.
New text reads:
"Bearings are reported in the WAM-V frame and coordinate system: the x-axis is towards the vehicle’s nose, the y-axis is towards the port side, and the z-axis points upwards. Following the right-hand rule, bearing angles are measured counter-clockwise beginning from the x-axis. "

@acxz
Copy link

acxz commented Jul 26, 2022

This is wonderful! Thank you so much @j-herman! 🤟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants